Optimize EDEngineer #715
Open
Optimize EDEngineer #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msarilar There are some benchmarks: Tried to apply a shopping list with every blueprint included 10 times with commit f1ec43c -- after 30 minutes application freezes (no GC happens, I heavily suspect OutOfMemoryException) Given my optimizations, import took ~20 seconds if you had almost empty shopping list before and choose to clean it. |
|
Nice thank you will try and review soonOn 12 Dec 2022, at 11:56, Mc-Pain ***@***.***> wrote:
@msarilar There are some benchmarks:
Tried to apply a shopping list with every blueprint included 10 times with commit f1ec43c -- after 30 minutes application freezes (no GC happens, I heavily suspect OutOfMemoryException)
Given my optimizations, import took ~20 seconds if you had almost empty shopping list before and choose to clean it.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
This should be resolved ASAP - that's why I took the attempt to optimize. |
|
ping? |
Mc-Pain
force-pushed
the
work-optimization
branch
from
7cdb398
to
68e7b82
Compare
Mc-Pain
force-pushed
the
work-optimization
branch
from
68e7b82
to
781e656
Compare
Mc-Pain
force-pushed
the
work-optimization
branch
from
781e656
to
b9b2316
Compare
|
@msarilar maybe your help is needed to optimize increment/decrement shopping list. What happens exactly when user/EDEvent changes shopping list? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ED Engineer operates very slow, especially on large shopping lists.
There are some bottlenecks and excessive operations when updating UI or importing/clearing shopping lists.
For example:
Multiple calling this.ToList(), which calculates a new object while we can store it somewhere if it's unchanged.
Updating UI or saving settings when importing or clearing shopping list (both are time expensive)
[source branch was renamed]